Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

chore: bump istio from 1.5.x to 1.6.x #317

Merged
merged 4 commits into from
Jun 25, 2020
Merged

chore: bump istio from 1.5.x to 1.6.x #317

merged 4 commits into from
Jun 25, 2020

Conversation

GoelDeepak
Copy link
Contributor

What type of PR is this?
Chore

What this PR does/ why we need it:
This PR move istio installation from KUDO back to helm. In the process it also upgrade it from 1.5.x to 1.6.x

Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-69720

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

istio addon upgraded to 1.6.3

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@GoelDeepak GoelDeepak requested a review from a team as a code owner June 25, 2020 07:11
@GoelDeepak GoelDeepak self-assigned this Jun 25, 2020
@dkoshkin
Copy link
Contributor

What upgrade do we care about?

  1. From the KUDO version
  2. From the older version
  3. Both?

@GoelDeepak
Copy link
Contributor Author

What upgrade do we care about?

  1. From the KUDO version
  2. From the older version
  3. Both?

None :). We care about upgradability going forward. So I tried upgrade from 1.5.4 to 1.6.3. Though we are releasing with 1.6.3

Copy link
Contributor

@jieyu jieyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR itself can be committed, but followups are needed.

Tested with konvoy master with istio enabled. Deployed bookinfo and verified that it worked.

However, all the dashboards in grafana are empty (showing no data) even if the bookinfo app has been deployed.

@joejulian joejulian merged commit dea1609 into master Jun 25, 2020
@joejulian joejulian deleted the deepak/istio branch June 25, 2020 19:31
joejulian pushed a commit that referenced this pull request Jul 8, 2020
* chore: copy the previous version to new version

* chore: bump istio from 1.5.x to 1.6.x

Co-authored-by: Sam Tran <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants